Review Request 124212: kwindowsystem: Change source file layout

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124212/
-----------------------------------------------------------

(Updated July 1, 2015, 8:20 a.m.)


Review request for KDE Frameworks.


Changes
-------

* added build fix for OSX
* renamed the implementation files to drop the window system suffix


Repository: kwindowsystem


Description
-------

In the src directory we introduce a platforms directory with a specific
* osx
* wayland
* windows
* xcb

sub directory. The platform specific source and header files are moved
into those directories.

This is a preparation step to move the platform specific behavior into
plugins which get loaded at runtime. Such a change is required to
support more platforms in future for which kwindowsystem cannot provide
support directly. An example is proper Wayland support on the Plasma
platform. It needs to provide its own implementationn which has to
differ from the generic Wayland implementation.


Diffs (updated)
-----

  autotests/CMakeLists.txt dda0af259b292ee5e526bb9166811fc1b376f388 
  src/CMakeLists.txt ff2ce392ecd7969eb94543528c7a670ea0fcd870 
  src/fixx11h.h  
  src/kkeyserver_mac.h  
  src/kkeyserver_mac.cpp  
  src/kkeyserver_win.h  
  src/kkeyserver_win.cpp  
  src/kkeyserver_x11.h  
  src/kkeyserver_x11.cpp  
  src/kmanagerselection.h  
  src/kselectionowner.h  
  src/kselectionowner.cpp  
  src/kselectionwatcher.h  
  src/kselectionwatcher.cpp  
  src/kwindoweffects_x11.cpp  
  src/kwindowinfo_mac.cpp  
  src/kwindowinfo_mac_p.h  
  src/kwindowinfo_p_x11.h  
  src/kwindowinfo_win.cpp  
  src/kwindowinfo_x11.cpp  
  src/kwindowsystem.cpp 789132e1b4883dd54218d29af9710dedfe6218e1 
  src/kwindowsystem_mac.cpp  
  src/kwindowsystem_p_wayland.h  
  src/kwindowsystem_p_x11.h  
  src/kwindowsystem_wayland.cpp  
  src/kwindowsystem_win.cpp  
  src/kwindowsystem_x11.cpp  
  src/kxerrorhandler.cpp  
  src/kxerrorhandler_p.h  
  src/kxmessages.h  
  src/kxmessages.cpp  
  src/kxutils.cpp  
  src/kxutils_p.h  
  src/netwm.h  
  src/netwm.cpp  
  src/netwm_p.h  
  src/platforms/CMakeLists.txt PRE-CREATION 
  src/platforms/osx/CMakeLists.txt PRE-CREATION 
  src/platforms/wayland/CMakeLists.txt PRE-CREATION 
  src/platforms/windows/CMakeLists.txt PRE-CREATION 
  src/platforms/xcb/CMakeLists.txt PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/124212/diff/


Testing
-------

compiles, installs and autotest pass on platform Linux/xcb


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150701/7c576464/attachment-0001.html>