Review Request 120833: Handle absolute paths without extension in KPluginLoader::findPlugin()

Alex Richardson arichardson.kde at gmail.com
Fri Jan 30 15:30:45 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120833/
-----------------------------------------------------------

(Updated Jan. 30, 2015, 3:30 p.m.)


Status
------

This change has been discarded.


Review request for KDE Frameworks, David Faure and Sebastian Kügler.


Repository: kcoreaddons


Description
-------

This means that e.g. KPluginLoader::findPlugin("/usr/lib/plugins/foo")
can now return "/usr/lib/plugins/foo.so" instead of an empty string.

Should this be done in Qt instead?


Diffs
-----

  autotests/kpluginloadertest.cpp 3ded0ebca2e0fd20e09bf6e4eca152d13ac11f46 
  src/lib/plugin/kpluginloader.cpp 802ef843bca4526cc9a4ee6780e8125453786b12 

Diff: https://git.reviewboard.kde.org/r/120833/diff/


Testing
-------

Unit test passes


Thanks,

Alex Richardson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150130/a54fcddc/attachment.html>


More information about the Kde-frameworks-devel mailing list