Review Request 122300: Fix quoteArgs for spaces that are not the regular space

Albert Astals Cid aacid at
Wed Jan 28 23:24:01 UTC 2015

This is an automatically generated e-mail. To reply, visit:

Review request for KDE Frameworks, David Faure and Michael Pyne.

Bugs: 343380

Repository: kcoreaddons


We need to also quote spaces like the Unicode character 'IDEOGRAPHIC SPACE' (U+3000) in KShell::quoteArg since KShell::splitArgs is using QChar::isSpace to decide when a new argument starts, without the quoting, one argument will get turned into two


  autotests/kshelltest.cpp 451bbe9 
  src/lib/util/kshell_unix.cpp e0e884f 



New test passes, bug 343380 is fixed


Albert Astals Cid

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the Kde-frameworks-devel mailing list