Review Request 122293: Use activate on single click setting from QPlatformTheme rather than duplicating it

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122293/#review74930
-----------------------------------------------------------

Ship it!


seems simple enough to me - if it still works, which it does even better than before if I understand you correctly. So +1 from my side, FWIW.

- Milian Wolff


On Jan. 28, 2015, 5:26 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122293/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2015, 5:26 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> -------
> 
> Our QPlatformTheme already provide a hint as to whether items should
> activate on single click and it updates when the setting changes
> 
> QCommonStyle by default uses the QPlatformTheme
> 
> This removes duplicating the lookup and also means we now update the
> setting if it changes at runtime
> 
> 
> Diffs
> -----
> 
>   src/kstyle/kstyle.cpp b5f7363 
> 
> Diff: https://git.reviewboard.kde.org/r/122293/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150128/676d7d64/attachment.html>