Review Request 122232: KConfig: fix using KSharedConfig in global object destructor.

David Faure faure at kde.org
Mon Jan 26 08:11:59 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122232/
-----------------------------------------------------------

(Updated Jan. 26, 2015, 8:11 a.m.)


Review request for KDE Frameworks and Matthew Dawson.


Changes
-------

made the requested changes


Repository: kconfig


Description
-------

kconfig_in_global_object.cpp comes from kdelibs4support
(after porting to Q_GLOBAL_STATIC)

ksharedconfig_in_global_object.cpp is new (but works with kdelibs4)
and reproduces Albert's KgDifficulty testcase.


Diffs (updated)
-----

  autotests/CMakeLists.txt b91f754b705fc87bb8b729bea72fbb5f7d427ace 
  autotests/kconfig_in_global_object.cpp PRE-CREATION 
  autotests/ksharedconfig_in_global_object.cpp PRE-CREATION 
  src/core/kconfig.cpp 782e9714521234a3e3d8f3a788967e5c9a40f38a 

Diff: https://git.reviewboard.kde.org/r/122232/diff/


Testing
-------

Both tests pass and the QCoreApplication::arguments warning (because called after qApp is destroyed) is gone.


Thanks,

David Faure

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150126/874334c9/attachment.html>


More information about the Kde-frameworks-devel mailing list