Review Request 122220: Don't show two progress dialogs for PasteJob

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122220/
-----------------------------------------------------------

(Updated Jan. 23, 2015, 10:34 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and David Faure.


Bugs: 342276
    https://bugs.kde.org/show_bug.cgi?id=342276


Repository: kio


Description
-------

PasteJob creates a copy/move job and passes its flags to it. These jobs then register with the progress dialog, but so does the original PasteJob and then there are two progress bars/dialogs.

This moves the registration to the job tracker only to the pasteMimeDataImpl job which does not take the flags of the parent job. I'm not sure if it makes sense there though. Alternatively it could be just removed.


Diffs
-----

  src/widgets/pastejob_p.h f5e68d3 

Diff: https://git.reviewboard.kde.org/r/122220/diff/


Testing
-------

Copying and moving files no longer spawns two progress dialogs.


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150123/d2893685/attachment.html>