Review Request 122183: [KUnitConversion] Currency: Fetch the currency file properly

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122183/
-----------------------------------------------------------

(Updated Jan. 23, 2015, 2:17 p.m.)


Review request for KDE Frameworks.


Changes
-------

This patch actually makes the test fail without changing the default values (another patch on reviewboard)


Bugs: 340819
    https://bugs.kde.org/show_bug.cgi?id=340819


Repository: kunitconversion


Description
-------

Currency: Fetch the currency file properly

Properly run an event loop and wait for the file to be fetched.

Also add a test to make sure currency conversion is working.

This patch also contains -
* https://git.reviewboard.kde.org/r/122182/
* https://git.reviewboard.kde.org/r/122181/
* https://git.reviewboard.kde.org/r/122180/

This is because reviewboard refuses to upload only a part of the diff. Please only look at currency.cpp w.r.t the EventLoop.


Diffs (updated)
-----

  autotests/convertertest.h 8129a48 
  autotests/convertertest.cpp ae4298e 
  src/currency.cpp 715233c 

Diff: https://git.reviewboard.kde.org/r/122183/diff/


Testing
-------

Test now passes.


Thanks,

Vishesh Handa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150123/3b64f8fc/attachment.html>