Review Request 122183: [KUnitConversion] Currency: Fetch the currency file properly

Vishesh Handa me at
Fri Jan 23 14:17:46 UTC 2015

This is an automatically generated e-mail. To reply, visit:

(Updated Jan. 23, 2015, 2:17 p.m.)

Review request for KDE Frameworks.


This patch actually makes the test fail without changing the default values (another patch on reviewboard)

Bugs: 340819

Repository: kunitconversion


Currency: Fetch the currency file properly

Properly run an event loop and wait for the file to be fetched.

Also add a test to make sure currency conversion is working.

This patch also contains -

This is because reviewboard refuses to upload only a part of the diff. Please only look at currency.cpp w.r.t the EventLoop.

Diffs (updated)

  autotests/convertertest.h 8129a48 
  autotests/convertertest.cpp ae4298e 
  src/currency.cpp 715233c 



Test now passes.


Vishesh Handa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the Kde-frameworks-devel mailing list