Review Request 122181: [KUnitConversion] UnitCategory convert: Call UnitCategoryPrivate instead of duplicating it

Vishesh Handa me at
Fri Jan 23 12:10:57 UTC 2015

This is an automatically generated e-mail. To reply, visit:

(Updated Jan. 23, 2015, 12:10 p.m.)


This change has been marked as submitted.

Review request for KDE Frameworks.

Repository: kunitconversion


  This is probably a mistake when implementing the private class. Both
  UnitCategoryPrivate::convert and UnitCategory::convert essentially
  the same thing. However, all sub categories modify the
  UnitCategoryPrivate virtual method, so we should be calling that one.
  This was caught while trying to debug the currency converter. It has its
  own custom convert function.


  src/unitcategory.cpp c34217e 



Fixes a test in another patch.


Vishesh Handa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the Kde-frameworks-devel mailing list