Review Request 122182: [KUnitConversion] Currency: Give default values for various currencies

[Vishesh Handa]

> On Jan. 22, 2015, 12:22 p.m., Martin Gräßlin wrote:
> > would it be possible to return an error if there is no useable value?
> > 
> > We can update now, but in a month or so the values could be completely different again (c.f. EUR - CHF from two weeks ago and today).

Given the way KUnitConversion is structured it would not be a trivial change.

Please note that this case will only ever occur if you use currency conversion the first time and there is no network access. The moment we have network access a more accurate currency file will be downloaded.


- Vishesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122182/#review74531
-----------------------------------------------------------


On Jan. 21, 2015, 2:47 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122182/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2015, 2:47 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kunitconversion
> 
> 
> Description
> -------
> 
> The currency converter works by fetching a file from the network every
> day and using those conversion values. If network is not available it
> will try and use the previous version of that file. If no file 
> then it will use the default values.
> 
> The default values was 1e+99 in all cases. This patch updates it to the
> current values as reflected in the file.
> 
> 
> Diffs
> -----
> 
>   src/currency.cpp 715233c 
> 
> Diff: https://git.reviewboard.kde.org/r/122182/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150122/45a03dc2/attachment.html>