Review Request 122182: [KUnitConversion] Currency: Give default values for various currencies

David Edmundson david at davidedmundson.co.uk
Thu Jan 22 12:17:35 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122182/#review74530
-----------------------------------------------------------


+1 

it seems better than returning nonsense even if it's slightly out of date.

- David Edmundson


On Jan. 21, 2015, 2:47 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122182/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2015, 2:47 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kunitconversion
> 
> 
> Description
> -------
> 
> The currency converter works by fetching a file from the network every
> day and using those conversion values. If network is not available it
> will try and use the previous version of that file. If no file 
> then it will use the default values.
> 
> The default values was 1e+99 in all cases. This patch updates it to the
> current values as reflected in the file.
> 
> 
> Diffs
> -----
> 
>   src/currency.cpp 715233c 
> 
> Diff: https://git.reviewboard.kde.org/r/122182/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150122/55c1db03/attachment.html>


More information about the Kde-frameworks-devel mailing list