Review Request 122180: [KUnitConversion] Unit::setUnitMultiplier: Do not call oneself

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122180/#review74480
-----------------------------------------------------------

Ship it!


Ship It!

- Aleix Pol Gonzalez


On Jan. 21, 2015, 3:47 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122180/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2015, 3:47 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kunitconversion
> 
> 
> Description
> -------
> 
> KUnitConversion: Unit::setUnitMultiplier: Do not call oneself
> 
> 
> Diffs
> -----
> 
>   src/unit.cpp 013b5d7 
> 
> Diff: https://git.reviewboard.kde.org/r/122180/diff/
> 
> 
> Testing
> -------
> 
> Created a test case in another patch. We no longer crash.
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150121/8b8797ea/attachment.html>