Review Request 122168: Also replace '.' by '_' when registering dbus path names from X_KDE_Library

[Hugo Pereira Da Costa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122168/
-----------------------------------------------------------

(Updated Jan. 21, 2015, 10:57 a.m.)


Review request for KDE Frameworks.


Changes
-------

only replace '.' in dbus path name, not in service name


Repository: kcmutils


Description
-------

Also replace '.' by '_' when registering dbus path names from X_KDE_Library
Rationale:
kwin requires that configuration components for kdecoration gets installed as kcmodule in $KF5/lib/plugins/org.kde.kdecoration2

Trying to make the said module for breeze directly loadable from kcmshell5, I hit 

ASSERT failure in QDBusConnection::registerObject: "Invalid object path given"


Diffs (updated)
-----

  src/kcmoduleproxy.cpp 630217a 

Diff: https://git.reviewboard.kde.org/r/122168/diff/


Testing
-------

yes, with code not pushed yet in breeze decoration config.
Before: crash (due to the above)
After: no crash.


Thanks,

Hugo Pereira Da Costa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150121/1ea987c3/attachment.html>