Review Request 122168: Also replace '.' by '_' when registering dbus path names from X_KDE_Library

[Hugo Pereira Da Costa]

> On Jan. 20, 2015, 4:16 p.m., David Faure wrote:
> > src/kcmoduleproxy.cpp, line 99
> > <https://git.reviewboard.kde.org/r/122168/diff/1/?file=343470#file343470line99>
> >
> >     ... while this line is happy with dots.
> 
> Hugo Pereira Da Costa wrote:
>     ok. Got it now. Thanks !

Stupid question: does it not also apply to the two lines above (replacement of '-' and '/' by '_') ? And if yes, should I also 'fix' that in the same review ?


- Hugo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122168/#review74403
-----------------------------------------------------------


On Jan. 20, 2015, 11:02 a.m., Hugo Pereira Da Costa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122168/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2015, 11:02 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcmutils
> 
> 
> Description
> -------
> 
> Also replace '.' by '_' when registering dbus path names from X_KDE_Library
> Rationale:
> kwin requires that configuration components for kdecoration gets installed as kcmodule in $KF5/lib/plugins/org.kde.kdecoration2
> 
> Trying to make the said module for breeze directly loadable from kcmshell5, I hit 
> 
> ASSERT failure in QDBusConnection::registerObject: "Invalid object path given"
> 
> 
> Diffs
> -----
> 
>   src/kcmoduleproxy.cpp 630217a 
> 
> Diff: https://git.reviewboard.kde.org/r/122168/diff/
> 
> 
> Testing
> -------
> 
> yes, with code not pushed yet in breeze decoration config.
> Before: crash (due to the above)
> After: no crash.
> 
> 
> Thanks,
> 
> Hugo Pereira Da Costa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150121/583b728d/attachment.html>