Review Request 122177: some minor fixes for windows

Allen Winter winter at kde.org
Tue Jan 20 23:05:02 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122177/#review74449
-----------------------------------------------------------



src/runtime/main.cpp
<https://git.reviewboard.kde.org/r/122177/#comment51638>

    yes, if you want to delete SESSION_MANAGER completely from the environment then use qunsetenv().  qunsetenv() is new since Qt 5.1.
    
    you don't need the conditional compile now.


- Allen Winter


On Jan. 20, 2015, 9:11 p.m., Patrick Spendrin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122177/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2015, 9:11 p.m.)
> 
> 
> Review request for KDE Frameworks and kdewin.
> 
> 
> Repository: kglobalaccel
> 
> 
> Description
> -------
> 
> some minor fixes for windows
> 
> 
> Diffs
> -----
> 
>   src/runtime/CMakeLists.txt a8fbfa1612a86f7371bf56926ec46fe14422a73a 
>   src/runtime/main.cpp f9cf9b353f00f1f68906d97f61cea5314a3663e4 
> 
> Diff: https://git.reviewboard.kde.org/r/122177/diff/
> 
> 
> Testing
> -------
> 
> windows msvc 2013
> 
> 
> Thanks,
> 
> Patrick Spendrin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150120/c8d56b4f/attachment.html>


More information about the Kde-frameworks-devel mailing list