Review Request 122168: Also replace '.' by '_' when registering dbus path names from X_KDE_Library

[Hugo Pereira Da Costa]

> On Jan. 20, 2015, 3:52 p.m., David Faure wrote:
> > for the path yes, but there is no reason to remove that from the service name....

mmm. Maybe I am confused with the comment. 
Still, I just checked that passing X-KDE-Library=kstyle_breeze_config.so
in the kcmodule .desktop also crashes dbus with the same assertion, without the patch
and is not crashing it (and loading the right library), when adding it.


- Hugo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122168/#review74399
-----------------------------------------------------------


On Jan. 20, 2015, 11:02 a.m., Hugo Pereira Da Costa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122168/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2015, 11:02 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcmutils
> 
> 
> Description
> -------
> 
> Also replace '.' by '_' when registering dbus path names from X_KDE_Library
> Rationale:
> kwin requires that configuration components for kdecoration gets installed as kcmodule in $KF5/lib/plugins/org.kde.kdecoration2
> 
> Trying to make the said module for breeze directly loadable from kcmshell5, I hit 
> 
> ASSERT failure in QDBusConnection::registerObject: "Invalid object path given"
> 
> 
> Diffs
> -----
> 
>   src/kcmoduleproxy.cpp 630217a 
> 
> Diff: https://git.reviewboard.kde.org/r/122168/diff/
> 
> 
> Testing
> -------
> 
> yes, with code not pushed yet in breeze decoration config.
> Before: crash (due to the above)
> After: no crash.
> 
> 
> Thanks,
> 
> Hugo Pereira Da Costa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150120/162232d9/attachment-0001.html>