Review Request 122149: Fix QCommandLineParser warnings in kcmshell5
Aleix Pol Gonzalez
aleixpol at kde.org
Mon Jan 19 15:21:11 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122149/
-----------------------------------------------------------
Review request for KDE Frameworks and David Faure.
Repository: kde-cli-tools
Description
-------
KCmdLineArgs used to define many arguments. In this case it was using --icon and --caption. At the moment, since we don't have these options we are getting warnings such as:
kcmshell5(19712)/(default) QCommandLineParserPrivate::aliases: QCommandLineParser: option not defined: "caption"
kcmshell5(19712)/(default) QCommandLineParserPrivate::aliases: QCommandLineParser: option not defined: "icon"
This patch addresses this by adding them explicitly in here. I'm unsure if we want to do any further engineering or that's good enough.
Diffs
-----
kcmshell/main.cpp 98e646b
Diff: https://git.reviewboard.kde.org/r/122149/diff/
Testing
-------
Ran it again, now it doesn't complain.
Thanks,
Aleix Pol Gonzalez
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150119/dbf4f9af/attachment.html>
More information about the Kde-frameworks-devel
mailing list