Review Request 122086: Add new method KWindowSystem::icons

Martin Gräßlin mgraesslin at kde.org
Mon Jan 19 13:50:50 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122086/
-----------------------------------------------------------

(Updated Jan. 19, 2015, 2:50 p.m.)


Review request for KDE Frameworks.


Changes
-------

Add an overload to read data from NETWinInfo.


Repository: kwindowsystem


Description
-------

::icons tries to retrieve all available icon sizes and combine them
into a single QIcon. On the X11 platform this can significantly
reduce the time needed to fetch all available icons compared to the
already existing ::icon methods which return a QPixmap of a specific
size.

The change includes a new test application "icontest" which shows all
available icons in all available sizes for a window id passed as
command line argument.

CHANGELOG: New method QIcon KWindowSystem::icons(WId win, int flags)


Diffs (updated)
-----

  src/kwindowsystem.h 322322f12dda7279567be8420533ed22cffffd52 
  src/kwindowsystem.cpp 65d215b6dfbf4df22e871fd7187fface75abb61b 
  src/kwindowsystem_p.h 1f01145b5c7efe925fcb8242f92af17b704e01c9 
  src/kwindowsystem_p_x11.h 0d4b6ba551776d2fa08030f78226ecdb3c80c889 
  src/kwindowsystem_x11.cpp bf958ae63b48424fc412405259f082b740928f9a 
  tests/CMakeLists.txt ce68cc505a69ea9a3cf645e9ae587bd89abe1648 
  tests/icontest.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/122086/diff/


Testing
-------


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150119/04e462c3/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list