Review Request 122093: Install lower- and camelcase headers to different subdirs

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122093/#review74293
-----------------------------------------------------------

Ship it!


Let's see. This is a namespaced framework ("namespace KPackage { class Foo ... }") so it should install headers the same way e.g. KParts does.

Indeed that means this patch is correct for the DESTINATION paths. I checked target_include_directories, looks ok already. All good.

- David Faure


On Jan. 16, 2015, 6:47 p.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122093/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2015, 6:47 p.m.)
> 
> 
> Review request for KDE Frameworks and Marco Martin.
> 
> 
> Bugs: 342899
>     https://bugs.kde.org/show_bug.cgi?id=342899
> 
> 
> Repository: kpackage
> 
> 
> Description
> -------
> 
> otherwise they get overwriten on case insensitive FS's..
> 
> 
> Diffs
> -----
> 
>   src/kpackage/CMakeLists.txt cd1ce00 
> 
> Diff: https://git.reviewboard.kde.org/r/122093/diff/
> 
> 
> Testing
> -------
> 
> builds... i expect plasma-framework shall still build
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150119/4fb027e2/attachment-0001.html>