Review Request 122007: Fix KTcpSocket to return correct negotiated protocol

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122007/#review74226
-----------------------------------------------------------

Ship it!


Ship It!

- David Faure


On Jan. 16, 2015, 6:14 a.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122007/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2015, 6:14 a.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Thiago Macieira.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> This pull request fixes a long standing issue in KTcpSocket where member functions "negotiatedSslVersion" and "negotiatedSslVersionName" returned the requested protocol instead of the actual negotiated one because QSslSocket did provide a means of accessing the actual negotiated protocol. Since this has been addressed in Qt 5.4, the problem should be fixed in KTcpSocket as well. Additionally the patch also adds support for Tlsv1_1 and TlsV1_2 protocols.
> 
> 
> Diffs
> -----
> 
>   src/core/ktcpsocket.h d59b180 
>   src/core/ktcpsocket.cpp f223986 
>   src/core/tcpslavebase.cpp e62e72a 
> 
> Diff: https://git.reviewboard.kde.org/r/122007/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150118/5a8efb48/attachment.html>