Review Request 121562: Fix build with Qt 5.5/dev branch in release mode

Aleix Pol Gonzalez aleixpol at kde.org
Sat Jan 17 20:11:52 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121562/#review74197
-----------------------------------------------------------

Ship it!


- Aleix Pol Gonzalez


On Jan. 17, 2015, 5:15 p.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121562/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2015, 5:15 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 342872
>     https://bugs.kde.org/show_bug.cgi?id=342872
> 
> 
> Repository: kitemmodels
> 
> 
> Description
> -------
> 
> since qtbase commit ebef2ad1360c80ad62de5f4a1c4e7e4051725c1c "Make the empty Q_ASSERT still check its argument for validity" the build shall fail.
> alternative is to guard the Q_ASSERT with QT_NO_DEBUG
> 
> 
> Diffs
> -----
> 
>   src/kselectionproxymodel.cpp 6774b75 
> 
> Diff: https://git.reviewboard.kde.org/r/121562/diff/
> 
> 
> Testing
> -------
> 
> does what it advertises
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150117/e4a97be8/attachment.html>


More information about the Kde-frameworks-devel mailing list