Review Request 122109: Cache QMetaMethods that are invoked on hot paths.

[Volker Krause]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122109/
-----------------------------------------------------------

(Updated Jan. 17, 2015, 6:10 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Milian Wolff.


Repository: kitemmodels


Description
-------

QMetaObject::invokeMethod calls QMetaObject::indexForMethod internally,
which is rather expensive. So look up the method once, and invoke it
via QMetaMethod directly.


Diffs
-----

  src/krecursivefilterproxymodel.cpp 241f2e8e7e610c397bebc6608a64e4f12e570aea 

Diff: https://git.reviewboard.kde.org/r/122109/diff/


Testing
-------

Tested and measured with the KRFPM usage in GammaRay, saves about 5% of total application CPU cost according to callgrind.


Thanks,

Volker Krause

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150117/ed067221/attachment.html>