Review Request 121737: KPluginInfo: Fix properties not being copied from KService::Ptr

[Alex Richardson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121737/
-----------------------------------------------------------

(Updated Jan. 16, 2015, 11:52 nachm.)


Review request for KDE Frameworks and David Faure.


Changes
-------

Added test

Note: KService::Ptr merges MimeTypes and ServicesTypes, is this intended or a bug? Makes the unit test unnecessarily complicated


Repository: kservice


Description
-------

This should fix property() returning empty QVariants even if it
existed in the .desktop file


Diffs (updated)
-----

  autotests/fakeplugin.desktop 9c6df7ffdb95f9e1b6e6f921040db00e8e5565ff 
  autotests/fakeplugin.json 067a302505956c34e940ce0f6facd8a1745384ec 
  autotests/kplugininfotest.cpp b520a9ca83e88fe5e4a2d53d4e05d7eb9764beea 
  src/services/kplugininfo.cpp 35e09fa49603a3c9fd5b534cacf46c18c848eaf4 

Diff: https://git.reviewboard.kde.org/r/121737/diff/


Testing
-------

KDED now correctly reads X-Kded-* in https://git.reviewboard.kde.org/r/121315/ instead of reading the default value.


Thanks,

Alex Richardson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150116/5bd758fe/attachment.html>