Review Request 122029: Fix generation of KAuth DBus helper service file

[Daniel Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122029/
-----------------------------------------------------------

(Updated Jan. 14, 2015, 11:34 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kauth


Description
-------

This fixes kauth_install_helper_files macro generating DBus service files with an invalid Exec entry, because the IS_ABSOLUTE condition was always evaluated to false, so when KAUTH_HELPER_INSTALL_DIR was in fact absolute, it became something like /usr//usr/libexec/kauth.

The invalid service caused KAuth::ExecuteJob to never finish in some cases, so when PowerDevil KDED module called .exec() on that job, it blocked forever, caused PowerDevil to never initialize completely and made the entire KDED running in a nested event loop, which does not accept user input events, so it was not possible to enter passwords into plasma-nm password dialog for example.

Interestingly this is only reproducible when there is no screen with backlight control available, which makes PowerDevil to "fallback" to using a backlight helper utility invoked through KAuth, and when KAuth is built with KAUTH_HELPER_INSTALL_DIR being already absolute path.


Diffs
-----

  cmake/KF5AuthMacros.cmake ab0b30a 

Diff: https://git.reviewboard.kde.org/r/122029/diff/


Testing
-------

After rebuilding PowerDevil against KAuth with this fix, PowerDevil KDED module fully initialized and plasma-nm auth dialog works again.


Thanks,

Daniel Vrátil

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150114/fa93abae/attachment.html>