Review Request 122039: ki18n: add BUILD_WITH_QTSCRIPT option.

[Albert Astals Cid]

> On gen. 13, 2015, 9:30 p.m., Albert Astals Cid wrote:
> > would it be possible to show some warning if compiled without qt script but the translation asks for it? or that is architerually hard?
> 
> Chusslove Illich wrote:
>     The Transcript plugin is internally loaded lazily, when the first scripted translation is seen. If the plugin was not compiled, this warning is shown:
>     
>       qWarning() << QString::fromLatin1("Cannot find Transcript plugin.");
>     
>     But it too could be compiled-away.

Ah cool, so the warning i wanted is already there, nice :)


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122039/#review73969
-----------------------------------------------------------


On gen. 13, 2015, 3:08 p.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122039/
> -----------------------------------------------------------
> 
> (Updated gen. 13, 2015, 3:08 p.m.)
> 
> 
> Review request for KDE Frameworks and Chusslove Illich.
> 
> 
> Repository: ki18n
> 
> 
> Description
> -------
> 
> Use case: to use KIO core in an embedded device, having to embed
> a javascript engine just for translations is overkill.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 2fbed024f392fefcb96dc8d3f6e421463280536c 
>   autotests/CMakeLists.txt f57af342217a2481cfa4dde1fd312b9c9d67ba48 
>   src/CMakeLists.txt ed5c789952372c2fcd3a8ca1b78ccb4ec2672840 
> 
> Diff: https://git.reviewboard.kde.org/r/122039/diff/
> 
> 
> Testing
> -------
> 
> Building with and without qtscript support works; ktranscript and its unittests are not built with the option is OFF.
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150114/a5352ec1/attachment.html>