Review Request 121922: support stringlists as properties
Marco Martin
notmart at gmail.com
Mon Jan 12 19:27:28 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121922/
-----------------------------------------------------------
(Updated Jan. 12, 2015, 7:27 p.m.)
Review request for KDE Frameworks.
Changes
-------
added a small test
Repository: kservice
Description
-------
if a property is defined as a StringList in a servicetype, return it as an actual stringlist upon KPluginInfo::property() instead of a string (with commas to separe the entries), having the same behavior of KService
This is necessary to have the same behavior between the old KServiceTypeTrader::query()
and
KPluginTrader::applyConstraints
because without list properties, all queries with the "in" keyword wouldn't work, such as
"org.kde.plasma.time in [X-Plasma-Provides]"
Diffs (updated)
-----
autotests/kservicetest.h 65939b3
autotests/kservicetest.cpp 8e96c64
src/services/kplugininfo.cpp aa5d263
Diff: https://git.reviewboard.kde.org/r/121922/diff/
Testing
-------
queries on list properties with "in" do work now
Thanks,
Marco Martin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150112/73557fdb/attachment.html>
More information about the Kde-frameworks-devel
mailing list