Review Request 122019: Fix crash in KGlobalAccel X11 runtime shutdown

David Edmundson david at davidedmundson.co.uk
Mon Jan 12 15:26:59 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122019/
-----------------------------------------------------------

Review request for KDE Frameworks.


Repository: kglobalaccel


Description
-------

As kglobalaccel is no longer a kdeinit executable it is not killed
gracefully in shutdown, when a user logs out it will be killed as the X
connection is removed.

GlobalShortcutsRegistry on deletion calls grabKey(key, false) to remove
any remaining grabs, since the X connection has gone any XCB results in
a crash.

This patch adds a guard around that.


Diffs
-----

  src/runtime/kglobalaccel_x11.cpp dfb03b5 

Diff: https://git.reviewboard.kde.org/r/122019/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150112/847beb05/attachment.html>


More information about the Kde-frameworks-devel mailing list