Review Request 121922: support stringlists as properties

[Marco Martin]

> On Jan. 9, 2015, 3:01 p.m., Alex Richardson wrote:
> > src/services/kplugininfo.cpp, line 535
> > <https://git.reviewboard.kde.org/r/121922/diff/2/?file=339120#file339120line535>
> >
> >     AFAIK escaping ; or , with a \ should be allowed: see KConfigGroupPrivate::deserializeList()

making it use a copy of it (that takes ; as well). that is of course not pretty but at least should work a tad better


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121922/#review73599
-----------------------------------------------------------


On Jan. 9, 2015, 4:52 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121922/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2015, 4:52 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kservice
> 
> 
> Description
> -------
> 
> if a property is defined as a StringList in a servicetype, return it as an actual stringlist upon KPluginInfo::property() instead of a string (with commas to separe the entries), having the same behavior of KService
> 
> This is necessary to have the same behavior between the old KServiceTypeTrader::query()
> and
> KPluginTrader::applyConstraints
> 
> because without list properties, all queries with the "in" keyword wouldn't work, such as
>  "org.kde.plasma.time in [X-Plasma-Provides]"
> 
> 
> Diffs
> -----
> 
>   src/services/kplugininfo.cpp aa5d263 
> 
> Diff: https://git.reviewboard.kde.org/r/121922/diff/
> 
> 
> Testing
> -------
> 
> queries on list properties with "in" do work now
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150109/2ba9f9cb/attachment-0001.html>