Review Request 121927: Update XCursor settings

David Faure faure at kde.org
Fri Jan 9 13:16:06 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121927/#review73585
-----------------------------------------------------------

Ship it!


OK I guess this is better for future extensibility. Right now it will lead to "unused variable" warnings on other platforms, but that's good, they indeed have something to fix there ;)

- David Faure


On Jan. 9, 2015, 12:24 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121927/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2015, 12:24 p.m.)
> 
> 
> Review request for KDE Frameworks, Àlex Fiestas and Eike Hein.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> -------
> 
> Code taken and adjusted from KGlobalSettings.
> 
> 
> Diffs
> -----
> 
>   autotests/CMakeLists.txt 00337e775e4e2d3e2d1bb583f4102323f0e5973b 
>   src/platformtheme/CMakeLists.txt 8a3b1b43d617083730517fe8db0a1e2f543913ab 
>   src/platformtheme/khintssettings.h 1d9c1d23c0974c6c76912536fb2879d72ca7dc6a 
>   src/platformtheme/khintssettings.cpp a477a1078f7d62294abfffc92a77889832b1e0db 
> 
> Diff: https://git.reviewboard.kde.org/r/121927/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150109/d6e5f88b/attachment.html>


More information about the Kde-frameworks-devel mailing list