Review Request 121927: Update XCursor settings

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121927/#review73559
-----------------------------------------------------------



autotests/CMakeLists.txt
<https://git.reviewboard.kde.org/r/121927/#comment51204>

    the HAVE_X11=0 seems very hackish to me; it wil prevent testing any X11 code path... I assume this is because we don't want the unittest touching the real X11 cursor, but then it would seem more accurate to just have -DUNIT_TEST here, and to say
    #if HAVE_X11 && !defined(UNIT_TEST)
    in the code.


- David Faure


On Jan. 8, 2015, 3:37 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121927/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2015, 3:37 p.m.)
> 
> 
> Review request for KDE Frameworks, Àlex Fiestas and Eike Hein.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> -------
> 
> Code taken and adjusted from KGlobalSettings.
> 
> 
> Diffs
> -----
> 
>   autotests/CMakeLists.txt 00337e775e4e2d3e2d1bb583f4102323f0e5973b 
>   src/platformtheme/CMakeLists.txt 8a3b1b43d617083730517fe8db0a1e2f543913ab 
>   src/platformtheme/khintssettings.cpp a477a1078f7d62294abfffc92a77889832b1e0db 
> 
> Diff: https://git.reviewboard.kde.org/r/121927/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150109/e2d9b158/attachment.html>