Review Request 121931: Unbreak KRecursiveFilterProxyModel for Qt 5.5.0+.

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121931/
-----------------------------------------------------------

(Updated Jan. 8, 2015, 6:10 p.m.)


Review request for KDE Frameworks and Stephen Kelly.


Changes
-------

cleanup


Repository: kitemmodels


Description
-------

The upstream commit f96baeb75fc36a41d2b08f880536cee5a8041e79
with the title:

QSortFilterProxyModel: honor the roles parameter of dataChanged

changes the signature of the private _q_sourceDataChanged slot
of QSortFilterProxyModel. I talked to Peppe and he told me to just
use the new signature from Qt 5.5 and onwards. Note that the vector
of roles was present in the dataChanged signal from 5.0 onwards
already. It was simply ignored by QSFPM so far.

Indeed, this patch fixes the following crash on Kate startup for me:

QMetaObject::invokeMethod: QMetaObject::invokeMethod: No such method
KRecursiveFilterProxyModel::_q_sourceDataChanged(QModelIndex,QModelIndex)
Candidates are:
    _q_sourceDataChanged(QModelIndex,QModelIndex,QVector<int>)
ASSERT: "success" in file
kf5/src/frameworks/kitemmodels/src/krecursivefilterproxymodel.cpp, line 55


Diffs (updated)
-----

  src/krecursivefilterproxymodel.h cf14c12d064c864e5fb03ccb1e741b57c615b127 
  src/krecursivefilterproxymodel.cpp b0753caea8693089873f161c123487a1893d5e01 

Diff: https://git.reviewboard.kde.org/r/121931/diff/


Testing
-------

sadly, there are no unit tests for this. but I can use Kate again without crashes and there are no warnings on startup either.


Thanks,

Milian Wolff

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150108/52fc77ea/attachment.html>