Review Request 121922: support stringlists as properties

[Albert Astals Cid]

> On gen. 8, 2015, 4:19 p.m., Milian Wolff wrote:
> > src/services/kplugininfo.cpp, line 533
> > <https://git.reviewboard.kde.org/r/121922/diff/2/?file=339120#file339120line533>
> >
> >     ',' or ';'.
> >     
> >     but, shouldn't it be only one or the other? isn't the .desktop file specification telling you which one it is? or is this all KDE custom? In KDevelop at least, the format always was "foo, bar, ...". Note the extra whitespace, which you are not trimming.
> 
> Marco Martin wrote:
>     the desktop file specification doesn't seem very clear on it, looking around on the web, seems that both , and ; could be used.
>     right now it gives priority to ; that i think is fine.
>     
>     about using json directly in new code (like kpackage i guess) i guess is possible, but i would rather add in the future the support for json, rather than forcing now, orbecomes less useful to gradually port legacy code

XDG uses ;
KConfig uses ,

http://tsdgeos.blogspot.com.es/2014/11/keywords-vs-x-kde-keywords-on-desktop.html


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121922/#review73512
-----------------------------------------------------------


On gen. 8, 2015, 3:34 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121922/
> -----------------------------------------------------------
> 
> (Updated gen. 8, 2015, 3:34 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kservice
> 
> 
> Description
> -------
> 
> if a property is defined as a StringList in a servicetype, return it as an actual stringlist upon KPluginInfo::property() instead of a string (with commas to separe the entries), having the same behavior of KService
> 
> This is necessary to have the same behavior between the old KServiceTypeTrader::query()
> and
> KPluginTrader::applyConstraints
> 
> because without list properties, all queries with the "in" keyword wouldn't work, such as
>  "org.kde.plasma.time in [X-Plasma-Provides]"
> 
> 
> Diffs
> -----
> 
>   src/services/kplugininfo.cpp aa5d263 
> 
> Diff: https://git.reviewboard.kde.org/r/121922/diff/
> 
> 
> Testing
> -------
> 
> queries on list properties with "in" do work now
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150108/d22e0904/attachment-0001.html>