Review Request 121922: support stringlists as properties

[Marco Martin]

> On Jan. 8, 2015, 2:48 p.m., Sebastian Kügler wrote:
> > I think https://git.reviewboard.kde.org/r/121672/diff/ tries to solve the same problem.
> 
> Marco Martin wrote:
>     yeah, that one seems to be more correct, will try that patch to see if it solves my problem as well

tested but nope, that patch doesn't seem to be enough, since it fixes it for KPluginMetadata, but a KPluginInfo from it doesn't work.
it needs to be fixed in KPluginInfo as well, since is what KPluginTrader::applyConstraints needs


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121922/#review73495
-----------------------------------------------------------


On Jan. 8, 2015, 2:24 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121922/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2015, 2:24 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kservice
> 
> 
> Description
> -------
> 
> if a property is defined as a StringList in a servicetype, return it as an actual stringlist upon KPluginInfo::property() instead of a string (with commas to separe the entries), having the same behavior of KService
> 
> This is necessary to have the same behavior between the old KServiceTypeTrader::query()
> and
> KPluginTrader::applyConstraints
> 
> because without list properties, all queries with the "in" keyword wouldn't work, such as
>  "org.kde.plasma.time in [X-Plasma-Provides]"
> 
> 
> Diffs
> -----
> 
>   src/services/kplugininfo.cpp aa5d263 
> 
> Diff: https://git.reviewboard.kde.org/r/121922/diff/
> 
> 
> Testing
> -------
> 
> queries on list properties with "in" do work now
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150108/314d58a1/attachment.html>