Review Request 121922: support stringlists as properties
Sebastian Kügler
sebas at kde.org
Thu Jan 8 14:48:07 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121922/#review73495
-----------------------------------------------------------
I think https://git.reviewboard.kde.org/r/121672/diff/ tries to solve the same problem.
- Sebastian Kügler
On Jan. 8, 2015, 2:24 p.m., Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121922/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2015, 2:24 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kservice
>
>
> Description
> -------
>
> if a property is defined as a StringList in a servicetype, return it as an actual stringlist upon KPluginInfo::property() instead of a string (with commas to separe the entries), having the same behavior of KService
>
> This is necessary to have the same behavior between the old KServiceTypeTrader::query()
> and
> KPluginTrader::applyConstraints
>
> because without list properties, all queries with the "in" keyword wouldn't work, such as
> "org.kde.plasma.time in [X-Plasma-Provides]"
>
>
> Diffs
> -----
>
> src/services/kplugininfo.cpp aa5d263
>
> Diff: https://git.reviewboard.kde.org/r/121922/diff/
>
>
> Testing
> -------
>
> queries on list properties with "in" do work now
>
>
> Thanks,
>
> Marco Martin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150108/600a9b23/attachment.html>
More information about the Kde-frameworks-devel
mailing list