Review Request 121885: Properly check for systray being available

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121885/
-----------------------------------------------------------

(Updated Jan. 8, 2015, 12:23 p.m.)


Review request for KDE Frameworks.


Changes
-------

Return to v1 of the patch


Bugs: 339707
    https://bugs.kde.org/show_bug.cgi?id=339707


Repository: frameworkintegration


Description
-------

The "org.kde.StatusNotifierWatcher" is just a watcher/helper, not the actual systray object, that's "org.kde.StatusNotifierHost-$PID". Because Plasma appends the PID, we cannot check directly for it being present on the bus, so we check the org.kde.StatusNotifierWatcher.IsStatusNotifierHostRegistered property that's meant to be used for this.

Plus QSystemTrayIcon::isSystemTrayAvailable() is actually returning always true, because the Watcher is in kded and is /always/ present.

This also fixes many apps with KSNI crashing on plasma exit, bug 339707 (though I believe this is not the direct cause for that bug)


Diffs (updated)
-----

  src/platformtheme/kdeplatformsystemtrayicon.cpp b5e207c 

Diff: https://git.reviewboard.kde.org/r/121885/diff/


Testing
-------

Things do not crash anymore and the ::isSystemTrayAvailable() now returns correct value.


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150108/003c5968/attachment.html>