Some more projects in need of respecting KF5_INSTALL_TARGETS_DEFAULT_ARGS

Alex Merry alex.merry at kde.org
Wed Jan 7 22:48:33 UTC 2015


On Wednesday 07 January 2015 20:15:54 Christoph Cullmann wrote:
> Hi,
> 
> I see why KDE_INSTALL_TARGETS_DEFAULT_ARGS and INSTALL_TARGETS_DEFAULT_ARGS
> fail on Mac, typo:
> 
> # on the Mac support an extra install directory for application bundles
> if(APPLE)
>     set(KDE_INSTALL_TARGETS_DEFAULT_ARGS  ${INSTALL_TARGETS_DEFAULT_ARGS}
>                                           BUNDLE DESTINATION
> "${BUNDLE_INSTALL_DIR}" ) set(KF5_INSTALL_TARGETS_DEFAULT_ARGS 
> ${KF5_INSTALL_TARGETS_DEFAULT_ARGS} BUNDLE DESTINATION
> "${BUNDLE_INSTALL_DIR}" ) endif(APPLE)
> 
> should be
> 
> # on the Mac support an extra install directory for application bundles
> if(APPLE)
>     set(KDE_INSTALL_TARGETS_DEFAULT_ARGS 
> ${KDE_INSTALL_TARGETS_DEFAULT_ARGS} BUNDLE DESTINATION
> "${BUNDLE_INSTALL_DIR}" ) set(KF5_INSTALL_TARGETS_DEFAULT_ARGS 
> ${KF5_INSTALL_TARGETS_DEFAULT_ARGS} BUNDLE DESTINATION
> "${BUNDLE_INSTALL_DIR}" ) endif(APPLE)

Oops. Well spotted! That wouldn't be caught by the unit tests, either, which 
just check the variable is set.

Alex


More information about the Kde-frameworks-devel mailing list