Some more projects in need of respecting KF5_INSTALL_TARGETS_DEFAULT_ARGS
alex.merry at kde.org
Wed Jan 7 18:42:52 UTC 2015
On Wednesday 07 January 2015 08:38:27 Kevin Funk wrote:
> On Tuesday 06 January 2015 23:55:48 Marko Käning wrote:
> > Hi Christoph,
> > I’ve found that these projects do not make use of
> > KF5_INSTALL_TARGETS_DEFAULT_ARGS at the moment:
> > - systemsettings
> > - muon
> > - rocs
> > - libkdegames
> > - kiten
> > - cantor
> > - kolourpaint
> > - libkmahjongg
> > See for details below in order of appearance.
> > I figure this is only the beginning of it and more projects might turn up
> > in the future.
> Is KF5_INSTALL_TARGETS_DEFAULT_ARGS even correct for non-frameworks
> projects? KF5_INSTALL_TARGETS_DEFAULT_ARGS's INCLUDES location points to
> KDEInstallDirs.cmake also has a KDE_INSTALL_TARGETS_DEFAULT_ARGS, which
> seems more appropriate.
> @Alex, please elaborate.
Nope, any variable from KDEInstallDirs.cmake with KF5 in the name is only for
the use of Frameworks. They all have a non-KF5 equivalent - in this case,
KDE_INSTALL_TARGETS_DEFAULT_ARGS, as you noticed.
I think KF5_INSTALL_TARGETS_DEFAULT_ARGS should actually be
KDE_INSTALL_TARGETS_DEFAULT_ARGS_KF5 for consistency with other variables, now
I look again.
More information about the Kde-frameworks-devel