Some more projects in need of respecting KF5_INSTALL_TARGETS_DEFAULT_ARGS

[Kevin Funk]

On Tuesday 06 January 2015 23:55:48 Marko Käning wrote:
> Hi Christoph,
> 
> I’ve found that these projects do not make use of
> KF5_INSTALL_TARGETS_DEFAULT_ARGS at the moment:
> 
>  - systemsettings
>  - muon
>  - rocs
>  - libkdegames
>  - kiten
>  - cantor
>  - kolourpaint
>  - libkmahjongg
> 
> See for details below in order of appearance.
> 
> I figure this is only the beginning of it and more projects might turn up in
> the future.

Is KF5_INSTALL_TARGETS_DEFAULT_ARGS even correct for non-frameworks projects?
KF5_INSTALL_TARGETS_DEFAULT_ARGS's INCLUDES location points to $SOMETHING/KF5.

KDEInstallDirs.cmake also has a KDE_INSTALL_TARGETS_DEFAULT_ARGS, which seems 
more appropriate.

@Alex, please elaborate.

> 
> Thanks for taking care of these.
> 
> Regards,
> Marko
> 
> 
> 
> 
> P.S.: I’ve tested locally to prepend "KF5_” to INSTALL_TARGETS_DEFAULT_ARGS
>       for project systemsettings only, which worked fine and made the
> project install successfully again here on my OSX/CI system.
> 
> 
> 
> 
> P.P.S.: I realised by now that there are no changes on the production
> branch, which probably means that there was some change in ECM or wherever
> provoking these issues...
> 
> 
> 
> 
> ---
> 
> systemsettings:
> 
> CMake Error at core/CMakeLists.txt:37 (install):
>   install TARGETS given no LIBRARY DESTINATION for shared library target
>   "systemsettingsview”.
> ---
> 
> muon:
> 
> CMake Error at libmuon/notifiers/CMakeLists.txt:7 (install):
>   install TARGETS given no LIBRARY DESTINATION for shared library target
>   "MuonNotifiers".
> 
> CMake Error at libmuon/CMakeLists.txt:63 (install):
>   install TARGETS given no LIBRARY DESTINATION for shared library target
>   "muonprivate”.
> ---
> 
> rocs:
> 
> CMake Error at libgraphtheory/CMakeLists.txt:106 (install):
>   install TARGETS given no LIBRARY DESTINATION for shared library target
>   "rocsgraphtheory”.
> ---
> 
> libkdegames:
> 
> CMake Error at CMakeLists.txt:163 (install):
>   install TARGETS given no LIBRARY DESTINATION for shared library target
>   "KF5KDEGames".
> 
> CMake Error at CMakeLists.txt:222 (install):
>   install TARGETS given no LIBRARY DESTINATION for shared library target
>   "KF5KDEGamesPrivate”.
> ---
> 
> kiten:
> 
> CMake Error at lib/CMakeLists.txt:37 (install):
>   install TARGETS given no LIBRARY DESTINATION for shared library target
>   "kiten".
> ---
> 
> cantor:
> 
> CMake Error at src/lib/CMakeLists.txt:75 (install):
>   install TARGETS given no LIBRARY DESTINATION for shared library target
>   "cantorlibs”.
> 
> CMake Error at src/CMakeLists.txt:25 (install):
>   install TARGETS given no LIBRARY DESTINATION for shared library target
>   "cantor_config".
> ---
> 
> kolourpaint:
> 
> CMake Error at CMakeLists.txt:579 (install):
>   install TARGETS given no LIBRARY DESTINATION for shared library target
>   "kolourpaint_lgpl".
> ---
> 
> libkmahjongg:
> 
> CMake Error at CMakeLists.txt:64 (install):
>   install TARGETS given no LIBRARY DESTINATION for shared library target
>   "KF5KMahjongglib".
> 
> CMake Error at CMakeLists.txt:67 (install):
>   install TARGETS given no LIBRARY DESTINATION for shared library target
>   "KF5KMahjongglib".
> ---
> 
> _______________________________________________
> Kde-frameworks-devel mailing list
> Kde-frameworks-devel at kde.org
> https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

-- 
Kevin Funk | kfunk at kde.org | http://kfunk.org