Review Request 121838: Fix KCoreConfigSkeleton when toggling a value with saves in between

Albert Astals Cid aacid at
Tue Jan 6 23:55:04 UTC 2015

This is an automatically generated e-mail. To reply, visit:

(Updated Jan. 6, 2015, 11:55 p.m.)


This change has been marked as submitted.

Review request for KDE Frameworks and Matthew Dawson.

Repository: kconfig


We need to refresh mLoadedValue after a save, otherwise the value is stale.

I'm doing this by resetting mLoadedValue to mReference in all the ::writeConfig.

I've also refactored the tests so they can be run independently now just fine.


  autotests/kconfigskeletontest.cpp f401b9f 
  src/core/kcoreconfigskeleton.h f8313d1 
  src/core/kcoreconfigskeleton.cpp e4255a6 
  CMakeLists.txt 205c38b 
  autotests/kconfigskeletontest.h c54c7b0 



My tests now pass.


Albert Astals Cid

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the Kde-frameworks-devel mailing list