Review Request 121838: Fix KCoreConfigSkeleton when toggling a value with saves in between

Albert Astals Cid aacid at kde.org
Tue Jan 6 22:41:02 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121838/
-----------------------------------------------------------

(Updated gen. 6, 2015, 10:41 p.m.)


Review request for KDE Frameworks and Matthew Dawson.


Changes
-------

Go the mLoadedValue=mReference way


Repository: kconfig


Description (updated)
-------

We need to refresh mLoadedValue after a save, otherwise the value is stale.

I'm doing this by resetting mLoadedValue to mReference in all the ::writeConfig.

I've also refactored the tests so they can be run independently now just fine.


Diffs (updated)
-----

  autotests/kconfigskeletontest.cpp f401b9f 
  src/core/kcoreconfigskeleton.h f8313d1 
  src/core/kcoreconfigskeleton.cpp e4255a6 
  CMakeLists.txt 205c38b 
  autotests/kconfigskeletontest.h c54c7b0 

Diff: https://git.reviewboard.kde.org/r/121838/diff/


Testing
-------

My tests now pass.


Thanks,

Albert Astals Cid

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150106/850a0948/attachment.html>


More information about the Kde-frameworks-devel mailing list