Review Request 121862: Move the kglobalaccel runtime into the framework

Martin Klapetek martin.klapetek at gmail.com
Tue Jan 6 14:56:59 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121862/
-----------------------------------------------------------

(Updated Jan. 6, 2015, 2:56 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks, David Faure, Martin Gräßlin, and Hrvoje Senjan.


Repository: kglobalaccel


Description
-------

This is a review request for the final move, I intentionally left out all the runtime/ files to not clutter this review (it's direct move from the workspace) and posting only the buildsystem and related changes.

The runtime daemon is now no longer a kdeinit executable, meaning the circular dependency should be no more.

Would be pretty awesome to get this into 5.6, so Plasma 5.2 can be shipped without it's own daemon copy.


Diffs
-----

  CMakeLists.txt 4077f69 
  metainfo.yaml d02975f 
  src/CMakeLists.txt 03fcbb9 
  src/runtime/CMakeLists.txt PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/121862/diff/


Testing
-------

kglobalaccel daemon works as expected


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150106/3b0d471a/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list