Review Request 121865: Fix cross compile error using Windows.h instead correctly windows.h.

David Faure faure at kde.org
Mon Jan 5 19:42:39 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121865/#review73199
-----------------------------------------------------------

Ship it!


the commit log is a bit confusing though. Did you mean instead of instead of instead? Haha LOL let me add some double quotes to that... Did you mean "instead of" instead of "instead"? :-)

- David Faure


On Jan. 5, 2015, 6:42 p.m., Ralf Habacker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121865/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2015, 6:42 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: karchive
> 
> 
> Description
> -------
> 
> Fix cross compile error using Windows.h instead correctly windows.h.
> 
> 
> Diffs
> -----
> 
>   src/karchive.cpp 4459d351caf17f9feea1d13d3870f35f12ba27cb 
> 
> Diff: https://git.reviewboard.kde.org/r/121865/diff/
> 
> 
> Testing
> -------
> 
> compiled package at https://build.opensuse.org/package/show/home:rhabacker:branches:windows:mingw:win32:KF5/mingw32-karchive
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150105/09ba4ba0/attachment.html>


More information about the Kde-frameworks-devel mailing list