Review Request 121838: Fix KCoreConfigSkeleton when toggling a value with saves in between

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121838/
-----------------------------------------------------------

Review request for KDE Frameworks and Matthew Dawson.


Repository: kconfig


Description
-------

We need to refresh mLoadedValue after a save, otherwise the value is stale.

I'm doing this by adding back the read() call in KCoreConfigSkeleton::save (which is what kdelibs did).

Another option would be adding lots of mLoadedValue = mReference; in all the ::writeConfig, but that seems much more prone.

I've also refactored the tests so they can be run independently now just fine.


Diffs
-----

  autotests/kconfigskeletontest.h c54c7b0 
  autotests/kconfigskeletontest.cpp f401b9f 
  src/core/kcoreconfigskeleton.cpp e4255a6 

Diff: https://git.reviewboard.kde.org/r/121838/diff/


Testing
-------

My tests now pass.


Thanks,

Albert Astals Cid

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150104/6e5be863/attachment.html>