Review Request 121838: Fix KCoreConfigSkeleton when toggling a value with saves in between

Albert Astals Cid aacid at
Sun Jan 4 16:04:53 UTC 2015

This is an automatically generated e-mail. To reply, visit:

Review request for KDE Frameworks and Matthew Dawson.

Repository: kconfig


We need to refresh mLoadedValue after a save, otherwise the value is stale.

I'm doing this by adding back the read() call in KCoreConfigSkeleton::save (which is what kdelibs did).

Another option would be adding lots of mLoadedValue = mReference; in all the ::writeConfig, but that seems much more prone.

I've also refactored the tests so they can be run independently now just fine.


  autotests/kconfigskeletontest.h c54c7b0 
  autotests/kconfigskeletontest.cpp f401b9f 
  src/core/kcoreconfigskeleton.cpp e4255a6 



My tests now pass.


Albert Astals Cid

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the Kde-frameworks-devel mailing list