Review Request 121792: Make KAboutData::setupCommandLine call addHelpOption and addVersionOption

[Albert Astals Cid]

> On gen. 2, 2015, 4:06 p.m., Aleix Pol Gonzalez wrote:
> > Can you check if an QCommandLineParser can get 2 of them?
> > 
> > Many applications are adding explicitly the addHelpOption, so with this they might get it twice?

Nah, it's fine, i just added

parser.addHelpOption();
parser.addVersionOption();
parser.addHelpOption();
parser.addVersionOption();

To one main.cpp and everything seems fine.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121792/#review72968
-----------------------------------------------------------


On gen. 2, 2015, 3:12 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121792/
> -----------------------------------------------------------
> 
> (Updated gen. 2, 2015, 3:12 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> It's something we used to do somewhere in kdelibs4 so people don't expect them to have to call this stuff manually. Also gives us some consistency.
> 
> 
> Diffs
> -----
> 
>   src/lib/kaboutdata.cpp f8d5e30 
> 
> Diff: https://git.reviewboard.kde.org/r/121792/diff/
> 
> 
> Testing
> -------
> 
> Ran one of my apps, now i have help and version.
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150102/9bee52d1/attachment.html>