Review Request 121792: Make KAboutData::setupCommandLine call addHelpOption and addVersionOption

[Aleix Pol Gonzalez]

> On Jan. 2, 2015, 3:33 p.m., Aleix Pol Gonzalez wrote:
> > We used to do this. It was removed because somebody (can't remember) considered it was misleading that the API would do things by itself.
> > 
> > I would welcome this (as well as the --help) but I'd like to hear what others think.
> 
> Albert Astals Cid wrote:
>     Why would it be misleading? It's seting up the command line, which is well, setting up the command line :D
>     
>     It's pretty depressing we don't care about consistency anymore, since this is not mentioned anywhere in the porting guides i'm pretty sure you can check almost all apps and none of them consistently calls both.

Well, since I knew about this, I've gone through many applications and fixed it myself.
But yes, I agree, hence my "I would welcome this".


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121792/#review72962
-----------------------------------------------------------


On Jan. 2, 2015, 3:12 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121792/
> -----------------------------------------------------------
> 
> (Updated Jan. 2, 2015, 3:12 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> It's something we used to do somewhere in kdelibs4 so people don't expect them to have to call this stuff manually. Also gives us some consistency.
> 
> 
> Diffs
> -----
> 
>   src/lib/kaboutdata.cpp f8d5e30 
> 
> Diff: https://git.reviewboard.kde.org/r/121792/diff/
> 
> 
> Testing
> -------
> 
> Ran one of my apps, now i have help and version.
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150102/d39754c3/attachment.html>