Review Request 121786: Fix crash accessing dangling pointer in NotifyByPopup

David Edmundson david at
Thu Jan 1 23:24:16 UTC 2015

This is an automatically generated e-mail. To reply, visit:

Review request for KDE Frameworks.

Repository: knotifications


sendNotificationToGalagoServer creates a new QDBusPendingCallWatcher for
a sent DBus message. It puts a pointer to the KNotification as a property on
the QObject.

If the local KNotification object got destroyed whilst that DBus
operation was happening this meant we would read a dangling pointer.

By setting the parent of the call watcher to the notification we can
make sure we don't process the call finishing if the notification no
longer exists.

BUG: 340845


  src/notifybypopup.cpp 66e593b 



Triggered a notification. It all still worked.


David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the Kde-frameworks-devel mailing list