Review Request 119607: Support for ".hidden" files

[Bruno Nova]

> On Jan. 1, 2015, 10:02 p.m., David Faure wrote:
> > Thanks for the updated patch.
> > 
> > I wrote a unittest for it, it works, so I pushed both, to wrap this up. Feel free to extend the test if you see missing testcases.
> > 
> > I'm not too happy about the sleep(1s) in the unittest, but the mtime comparison required it (to avoid using an old cache).
> > I guess the alternative would be to also store the file size in CacheHiddenFile, but it sounds like this would only be useful for the unittest, I can't think of a real-life problem with mtime having a 1s resolution.

Great! Thank you for unittest!

I think the unittest could also test filenames with spaces, like "  with spaces " and " " (yes, one space).


- Bruno


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119607/#review72882
-----------------------------------------------------------


On Jan. 1, 2015, 9:55 p.m., Bruno Nova wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119607/
> -----------------------------------------------------------
> 
> (Updated Jan. 1, 2015, 9:55 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Bugs: 64740 and 246260
>     https://bugs.kde.org/show_bug.cgi?id=64740
>     https://bugs.kde.org/show_bug.cgi?id=246260
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> This adds support for *.hidden* files to KDE.
> 
> When listing a directory, the files/folders listed in the *.hidden* file will be hidden, unless the user has chosen to show hidden files.
> 
> This patch was initially based on the patch provided by Mark in Bug #246260.
> 
> 
> Diffs
> -----
> 
>   src/core/kcoredirlister.cpp f5c5627 
>   src/core/kcoredirlister_p.h db096c5 
>   src/core/kfileitem.h a815aee 
>   src/core/kfileitem.cpp 6a2cfa5 
> 
> Diff: https://git.reviewboard.kde.org/r/119607/diff/
> 
> 
> Testing
> -------
> 
> Built and tested the patch in Project Neon.
> Dolphin was still using KDE4/Qt4 version of the library, so I only tested using the desktop folder widget, and "folder desktop".
> It worked correctly when I pointed it to "~" and "~/Desktop" (I added ".hidden" there).
> However, it didn't work when I pointed it to the "Desktop folder" (the default option, not the custom location "~/Desktop").
> More testing is required.
> 
> The version for KDE4/Qt4 submitted to Bug #246260 was tested in Kubuntu 14.04, and it worked everywhere I tested (Dolphin, open/save dialogs, folder widget and detailed/tree view in Dolphin).
> It wasn't an intensive test, though.
> 
> 
> Thanks,
> 
> Bruno Nova
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150101/5e432729/attachment-0001.html>