Review Request 122754: Remove use of KI18N_MODULE_DIR.

Alex Merry alex.merry at kde.org
Sat Feb 28 13:45:04 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122754/
-----------------------------------------------------------

Review request for KDE Frameworks and Chusslove Illich.


Repository: ki18n


Description
-------

This variable (and the corresponding if/else in KF5I18NMacros) is
unnecessary, as the scripts needed by KF5I18NMacros.cmake are always in
the same directory as KF5I18NMacros.cmake.

We keep the variable, albeit set in a simpler way, in case anything else
is using it (by the CMake naming convention, a variable with no leading
underscore is public).


Diffs
-----

  KF5I18nConfig.cmake.in 64dc5009e4821f9e1bb3631c596b56e66c578c3c 
  cmake/KF5I18NMacros.cmake a55f472bdfdebd2e353064f102c1f1372fdf0918 

Diff: https://git.reviewboard.kde.org/r/122754/diff/


Testing
-------

Built, run `make test`.


Thanks,

Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150228/a7e3d553/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list