Review Request 122621: Implemented SlaveBase::GetFileSystemFreeSpace in sftp ioslave

[Vishesh Handa]

> On Feb. 25, 2015, 10:24 a.m., Vishesh Handa wrote:
> > sftp/kio_sftp.cpp, line 247
> > <https://git.reviewboard.kde.org/r/122621/diff/1/?file=350141#file350141line247>
> >
> >     The code indentation seems wrong.
> 
> Emmanuel Pescosta wrote:
>     Just followed the coding style (1 tab -> 2 spaces) from kio_sftp.cpp
>     
>     Should I use the frameworks coding style instead?

Ah. I didn't see the rest of the file. Probbaly best to follow it, like you have :)


- Vishesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122621/#review76592
-----------------------------------------------------------


On Feb. 18, 2015, 11:14 a.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122621/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2015, 11:14 a.m.)
> 
> 
> Review request for KDE Frameworks and Andreas Schneider.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> -------
> 
> Implemented SlaveBase::GetFileSystemFreeSpace to enable free space information in sftp ioslave.
> 
> 
> Diffs
> -----
> 
>   sftp/kio_sftp.h e088472 
>   sftp/kio_sftp.cpp 057fcd4 
> 
> Diff: https://git.reviewboard.kde.org/r/122621/diff/
> 
> 
> Testing
> -------
> 
> Works
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150226/0e52fd7e/attachment.html>