Review Request 122607: Better support for non-platform xcb in KXMessages

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122607/
-----------------------------------------------------------

(Updated Feb. 23, 2015, 12:08 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kwindowsystem


Description
-------

The static methods of KXMessages already support being used without
platform xcb (and that way without a QGuiApplication). This change
makes it possible to also use KXMessages without platform xcb. A new
ctor overload is added which accepts the xcb_connection_t* and the
root window to be used. The existing ctor still uses QX11Info and
verifies that it is used on platformX11.


Diffs
-----

  autotests/kxmessages_unittest.cpp 6ffa9046fc325a0f273a2480a925c4299941a9ca 
  src/kxmessages.h b3d7ebcdb33356ceeb0a0821b8987efb454793c6 
  src/kxmessages.cpp 9f614f7fe02893974194e607911e369d65ef3830 

Diff: https://git.reviewboard.kde.org/r/122607/diff/


Testing
-------


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150223/9813e270/attachment.html>