Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122680/#review76460
-----------------------------------------------------------



src/runtime/main.cpp
<https://git.reviewboard.kde.org/r/122680/#comment52670>

    This exposes the KAboutData information as the application's information.
    
    I'll leave up to the maintainer to decide whether it's useful or not.


That said, you're removing 2 very small dependencies there...

- Aleix Pol Gonzalez


On Feb. 23, 2015, 11:34 a.m., Jerome Leclanche wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122680/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2015, 11:34 a.m.)
> 
> 
> Review request for KDE Frameworks, Martin Gräßlin and Martin Klapetek.
> 
> 
> Repository: kglobalaccel
> 
> 
> Description
> -------
> 
> Remove the runtime's KAboutData
>     
> The about data was unexposed, but created a dependency on KCoreAddons (for
> KAboutData) and in turn on KI18n for the translations of the aboutData.
>     
> This removes both dependencies as well as the string extraction scripts.
> 
> --
> 
> Author notes: This is a RFC. We don't use kglobalaccel in LXQt but we would
> like to, however it currently has too many dependencies. See
> https://github.com/lxde/lxqt/issues/507 for related discussion.
> I'm unsure myself if the about data is actually exposed somewhere I completely
> missed, but it doesn't look that way.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 68ad795 
>   src/Messages.sh 8eae937 
>   src/runtime/CMakeLists.txt e639fa5 
>   src/runtime/Messages.sh 8a5e4a9 
>   src/runtime/globalshortcutsregistry.cpp 3e4d720 
>   src/runtime/kglobalacceld.cpp 4e7cb9d 
>   src/runtime/main.cpp fdf4d62 
> 
> Diff: https://git.reviewboard.kde.org/r/122680/diff/
> 
> 
> Testing
> -------
> 
> Compiles and runs. No further testing done.
> 
> 
> Thanks,
> 
> Jerome Leclanche
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150223/198a75cc/attachment.html>